Changelog - April 3 through April 9
We cut an Enterprise release on March 23rd, but as you've seen our changelogs have been pretty extensive, so we will be cutting a new one. As of publishing, it's been uploaded, see the for info. This changelog is therefore small and mostly fixing corner cases in response to error and bug reports.
Code Review Experience
File-level comments from GitHub are supported properly
Recently, GitHub added file-level comments (but still don't support comments more than 3 lines away from the diff? 🤷♂) so we added handling for those comments so they're mapped correctly and show up in Reviewable in the right place.
Comments on hidden-diff files don't hog your screen space
Sometimes, you see comments on files that don't have the diff shown, such as generated files or when the completion condition said the file isn't relevant. We fixed an issue where that comment would take up the whole width of your browser, even when the browser is wide enough to show a side-by-side diff for all the other files.
Discerning between GitHub Comment Threads
Previously, if there were multiple threads on the same line in a file, sent from GitHub, we would merge the threads. Thankfully they have a comment ID to allow us to discern which thread a comment is being added to, so this should be working.
There were some race conditions with loading a PR's revisions and its changed files (after doing rename calculation) that caused some errors to be reported to us. This would have resulted in blank numbers for this information, so you likely didn't notice, but I'm telling you anyway.
Lack of admins got you down? No longer! Well, less!
GitHub's API has a burst quota limit that we try to load balance across multiple admins, but if the ratio of users to admins is too high we'll still hit that limit. Now, we delayed some lower priority tasks in favor of the higher priority tasks. The only corner case we think this is noticeable is if your repository has many open PR's including some really old ones, then those old ones may not update in response to reviews as quickly as theoretically possible. However, more than likely, other PR's weren't updating as well due to the quota limit, so this should only be a positive in reality.
for serious code reviews